[FIX] Changes on department agents should mark form as dirty#19640
Merged
[FIX] Changes on department agents should mark form as dirty#19640
Conversation
Contributor
|
@rafaelblink can you, please, fix the conflicts here? |
Member
|
@renatobecker do you still need the fix present in this PR? I can handle the conflicts to push it! |
dougfabris
previously approved these changes
Dec 20, 2021
KevLehman
approved these changes
Dec 21, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Form validation isn't checking if are some new agents or event changes in existing agents to turn the "Save" button clickable, so I created a method to check this.
Issue(s)
How to test or reproduce
Omnichannel - Deparments Page
Edit departments with some agents and try to change the count, order, or even remove some and add, the "save" button won't be able to click.
Screenshots
Types of changes
Checklist
Changelog
Further comments