[FIX] Adding retentionEnabledDefault check before showing warning message #20692
Merged
ggazzo merged 6 commits intoRocketChat:developfrom May 12, 2021
Merged
[FIX] Adding retentionEnabledDefault check before showing warning message #20692ggazzo merged 6 commits intoRocketChat:developfrom
ggazzo merged 6 commits intoRocketChat:developfrom
Conversation
Member
Author
Member
Author
|
@ggazzo @dougfabris this pr is ready for review. :) |
Member
Author
|
@ggazzo @dougfabris Please have a look. Thanks :) |
KevLehman
reviewed
May 4, 2021
ggazzo
approved these changes
May 12, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed changes (including videos or screenshots)
Added check for retentionEnabledDefault before showing prune warning message.
Issue(s)
fixes #20685
Steps to test or reproduce
Check issue
Further comments
Before showing message in RoomInfo, we were only checking for global retentionPolicyEnabled, we were not checking for the channel or dm or group policy. So added check for that.
So when these 3 are off, warning should not be shown in respective types of channels.