[FIX] Visibility of burger menu on certain width#20736
Merged
ggazzo merged 6 commits intoRocketChat:developfrom May 10, 2021
Merged
[FIX] Visibility of burger menu on certain width#20736ggazzo merged 6 commits intoRocketChat:developfrom
ggazzo merged 6 commits intoRocketChat:developfrom
Conversation
Member
Author
|
@ggazzo @MartinSchoeler Please review. :) |
Member
Author
|
@ggazzo @MartinSchoeler Please review. :) |
Member
Author
|
@dougfabris Please have a look. Thanks :) |
Member
Author
|
@ggazzo please review. |
|
I really hope the fix will be merged soon. This is indeed a quite annoying UI-problem. |
Member
Author
|
@ggazzo Please have a look at this :) |
dougfabris
previously approved these changes
Apr 20, 2021
Member
Author
|
Ohh, I didn't notice the conflicts, will resolve in sometime. |
ggazzo
approved these changes
May 10, 2021
Merged
|
Thank you for working on this. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Burger was not visible on a certain width, specifically between 600 to 780. if width is more than 780px sidebar is shown, if less than 600 then burger icon was shown. But it wasn't shown between 600px to 780 px.
It was because for showing burger icon we were only checking for
isMobilewhich is lenght only less than 600. So i added one more check for condition if length is less than 780 px.Issue(s)
fixes #20499 #20859
Steps to test or reproduce
Further comments
Earlier
After