[FIX] Removed fields from User Info for which the user doesn't have permissions.

[Darshilp326]

Proposed changes (including videos or screenshots)

Removed LastLogin, CreatedAt and Roles for users who don't have permission.

Correct-info-pr.mp4

Issue(s)

Closes #20138
Closes #20394

Steps to test or reproduce

Further comments

In video second user is an Admin.

[Darshilp326]

@dougfabris Please review 😄

[lgtm-com]

This pull request introduces 1 alert when merging d1292cc into 82243ad - view on LGTM.com

new alerts:

• 1 for Useless conditional

[suninuni]

Rocket.Chat/app/lib/server/functions/getFullUserData.js

Lines 94 to 95 in 1202b45

	const user = Users.findOneByIdOrUsername(filterId || filterUsername, options);
	user.canViewAllInfo = canViewAllInfo;

This caused a unexpected error when user is not found. @Darshilp326 @dougfabris

{
    "success": false,
    "error": "Cannot set property 'canViewAllInfo' of undefined"
}

[dougfabris]

Rocket.Chat/app/lib/server/functions/getFullUserData.js

Lines 94 to 95 in 1202b45

	const user = Users.findOneByIdOrUsername(filterId || filterUsername, options);
	user.canViewAllInfo = canViewAllInfo;

This caused a unexpected error when user is not found. @Darshilp326 @dougfabris

{
    "success": false,
    "error": "Cannot set property 'canViewAllInfo' of undefined"
}

@suninuni The issue you mentioned is already fixed: #23372
Thanks for reporting!