[NEW][APPS] Possibility to set room closer via Apps LivechatBridge.closeRoom#21025
Merged
d-gubert merged 2 commits intoRocketChat:developfrom Dec 10, 2021
Merged
Conversation
cuonghuunguyen
force-pushed
the
set-room-closer-for-apps-engine
branch
2 times, most recently
from
2b259e6 to
5f17c3f
Compare
cuonghuunguyen
force-pushed
the
set-room-closer-for-apps-engine
branch
from
42b6d92 to
0c1612f
Compare
lucassartor
reviewed
Mar 30, 2021
cuonghuunguyen
force-pushed
the
set-room-closer-for-apps-engine
branch
2 times, most recently
from
232daac to
0fbb310
Compare
renatobecker
previously requested changes
Sep 6, 2021
cuonghuunguyen
force-pushed
the
set-room-closer-for-apps-engine
branch
from
0fbb310 to
57fbc24
Compare
cuonghuunguyen
force-pushed
the
set-room-closer-for-apps-engine
branch
from
57fbc24 to
8957808
Compare
d-gubert
previously approved these changes
Dec 10, 2021
Member
d-gubert
left a comment
d-gubert
left a comment
There was a problem hiding this comment.
Thank you for the contribution!!
d-gubert
dismissed
their stale review
This was supposed to be in the PR referring to this in the Apps-Engine repo lol
d-gubert
changed the title
d-gubert
approved these changes
Dec 10, 2021
Member
d-gubert
left a comment
d-gubert
left a comment
There was a problem hiding this comment.
For realz now, thank you for the contribution!! :D
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Add an optional param named
closerintoLivechatBridge.closeRoomso that it will be possible to close the room and send a close room message with the correct room closer.If the param is not passed, use the room visitor as the room closer.
Issue(s)
closes RocketChat/Rocket.Chat.Apps-engine#373
Apps-Engine's PR: RocketChat/Rocket.Chat.Apps-engine#391
Steps to test or reproduce
Further comments