[IMPROVE] Quote fragment of a message#21290
Closed
sammyzord wants to merge 4 commits intoRocketChat:developfrom
Closed
[IMPROVE] Quote fragment of a message#21290sammyzord wants to merge 4 commits intoRocketChat:developfrom
sammyzord wants to merge 4 commits intoRocketChat:developfrom
Conversation
|
This pull request introduces 1 alert and fixes 1 when merging 7bb5861 into a92800b - view on LGTM.com new alerts:
fixed alerts:
|
sammyzord
force-pushed
the
quote-fragment-of-message
branch
from
7bb5861 to
a98bd36
Compare
…ing the desired part Co-authored-by: Mikhaelle Bueno <mikhabueno@outlook.com>
sammyzord
force-pushed
the
quote-fragment-of-message
branch
from
a98bd36 to
8cbb367
Compare
|
This pull request introduces 1 alert and fixes 1 when merging 8cbb367 into a92800b - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 1 when merging 54128ed into f01b255 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 1 alert when merging 2056141 into f01b255 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging a8b83f5 into 3df8181 - view on LGTM.com fixed alerts:
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Adds functionality of selecting only a fragment of a message and quoting it, displaying only the relevant part of the message in the quote. It uses URL query parameters in the quote markdown to determine the start and the end of a quote. Quoted fragment is prepended and appended by
[...]to avoid messages being taken out of context.Issue(s)
Closes RocketChat/feature-requests#877
Steps to test or reproduce
Adds a new message action button when the user selects part of the message's text
Quoted fragment is displayed as below
Further comments