[IMPROVE] Add support to queries in channels.members and groups.members endpoints#21414
Merged
sampaiodiego merged 11 commits intodevelopfrom May 14, 2021
Merged
[IMPROVE] Add support to queries in channels.members and groups.members endpoints#21414sampaiodiego merged 11 commits intodevelopfrom
channels.members and groups.members endpoints#21414sampaiodiego merged 11 commits intodevelopfrom
Conversation
sampaiodiego
requested changes
Apr 8, 2021
Member
sampaiodiego
left a comment
There was a problem hiding this comment.
Can you please change this PR to make it similar to #21471 in terms of parameters accepted.. thx
KevLehman
reviewed
Apr 19, 2021
KevLehman
reviewed
Apr 26, 2021
Member
KevLehman
left a comment
There was a problem hiding this comment.
The only thing that I think this is missing is support for search (by username, name, etc). But the basic support for the query params looks good :)
channels.members and groups.members endpointschannels.members and groups.members endpoints
sampaiodiego
approved these changes
May 13, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
queryparameter) inchannels.membersandgroups.membersendpoints.Issue(s)
Task - ClickUp
Steps to test or reproduce
Example input (using cURL):
Further comments