Skip to content

Chore: Add mongo 4.2 to array of mongo versions supported#21550

Merged
sampaiodiego merged 4 commits intodevelopfrom
add/mongodb-4-2
Apr 28, 2021
Merged

Chore: Add mongo 4.2 to array of mongo versions supported#21550
sampaiodiego merged 4 commits intodevelopfrom
add/mongodb-4-2

Conversation

@KevLehman
Copy link
Member

Proposed changes (including videos or screenshots)

  • MongoDB 4.2 is now supported

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman requested a review from a team April 13, 2021 22:36
@sampaiodiego
Copy link
Member

I was not sure to what happened before https://github.com/RocketChat/Rocket.Chat/pull/21550/checks?check_run_id=2338185382#step:7:9

so I have updated with base branch so the CI runs again

@KevLehman
Copy link
Member Author

It appears the same happened again 🤔 weird, but seems like the Mongo container won't start on 4.2

@KevLehman
Copy link
Member Author

Maybe @geekgonecrazy can help us on this one 👀 since to me it's unlikely this is a changes-related issue 😬

@sampaiodiego
Copy link
Member

maybe MongoDB 4.2 doesn't accept the other params we're using 🤔 like --noprealloc --smallfiles --replSet=rs0

I was also looking into other Actions:

but for this particular issue, my bet are on those additional params.

@KevLehman
Copy link
Member Author

Yeah, it looks like those options are tied to the nmap engine, so probably the 4.2 doesn't know what to do with them.

@KevLehman
Copy link
Member Author

As expected, removing the mmap flags worked 😬 since the flags were mostly "informative", what do you think about removing those flags at all?

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine =)

@sampaiodiego sampaiodiego changed the title Add mongo 4.2 to array of mongo versions supported Chore: Add mongo 4.2 to array of mongo versions supported Apr 28, 2021
@sampaiodiego sampaiodiego merged commit 629c56d into develop Apr 28, 2021
@sampaiodiego sampaiodiego deleted the add/mongodb-4-2 branch April 28, 2021 20:58
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments