[FIX] Unable to edit a 'direct' room setting in the admin due to the room name#21636
Merged
sampaiodiego merged 14 commits intoRocketChat:developfrom Apr 29, 2021
Jeanstaquet:FixSaveRoomInfoAdmin
Merged
[FIX] Unable to edit a 'direct' room setting in the admin due to the room name#21636sampaiodiego merged 14 commits intoRocketChat:developfrom Jeanstaquet:FixSaveRoomInfoAdmin
sampaiodiego merged 14 commits intoRocketChat:developfrom
Jeanstaquet:FixSaveRoomInfoAdmin
Conversation
updating the code
updating the code
updating the fork
update main branch
updating the branch
Update fork
Upating the fork
Updating fork
Updating fork
Jeanstaquet
changed the title
KevLehman
previously approved these changes
Apr 19, 2021
sampaiodiego
requested changes
Apr 28, 2021
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
IMHO a proper fix for this issue would be changing the frontend to actually not send the room name on payload since that was not changed (the field is event disabled). if the name is sent on the payload, the backend should validate it, otherwise let's say someone uses the endpoint providing only the room name, the endpoint will return success but nothing will be done, which I'd consider a bug.
Contributor
Author
|
@sampaiodiego alright, i will do the changes ASAP 👍 |
Contributor
Author
|
Proof that it works: 2021-04-29.01-51-17.mp4 |
sampaiodiego
approved these changes
Apr 29, 2021
gabriellsh
added a commit
that referenced
this pull request
Apr 29, 2021
…autolinker-phone * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Unable to edit a 'direct' room setting in the admin due to the room name (#21636)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When you are in the admin and want to change a room 'd' setting, it doesn't work because it takes into account the name that is set automatically and therefore tries to save that name. Since the name is not valid and should not be registered, we cannot change the setting for the 'd' room.
I made sure that when you want to change a setting in a 'd' room, that you don't take the name into account
2021-04-18.17-10-16.mp4
Behind the scene, the name is not saved
Issue(s)
Fixes #21635
Steps to test or reproduce
Further comments