[FIX] Custom OAuth not being completely deleted#21637
Merged
sampaiodiego merged 1 commit intoRocketChat:developfrom Apr 29, 2021
siva2204:fix/delete-custom-oauth
Merged
[FIX] Custom OAuth not being completely deleted#21637sampaiodiego merged 1 commit intoRocketChat:developfrom siva2204:fix/delete-custom-oauth
sampaiodiego merged 1 commit intoRocketChat:developfrom
siva2204:fix/delete-custom-oauth
Conversation
KevLehman
previously approved these changes
Apr 19, 2021
KevLehman
approved these changes
Apr 21, 2021
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
custom OAuth is partially deleted after clicking delete custom oauth button in admin settings.
before
Screencast.from.19-04-21.02.29.51.AM.IST.mp4
after
Screencast.from.19-04-21.02.12.19.AM.IST.mp4
Issue(s)
#21280
Steps to test or reproduce
check issue page
Further comments