[IMPROVE] Improve the add user drop down for add a user in create channel modal for UserAutoCompleteMultiple#21649
Closed
Jeanstaquet wants to merge 21 commits intoRocketChat:developfrom
Jeanstaquet:NewAddUserDropDown
Closed
[IMPROVE] Improve the add user drop down for add a user in create channel modal for UserAutoCompleteMultiple#21649Jeanstaquet wants to merge 21 commits intoRocketChat:developfrom Jeanstaquet:NewAddUserDropDown
Jeanstaquet wants to merge 21 commits intoRocketChat:developfrom
Jeanstaquet:NewAddUserDropDown
Conversation
updating the code
updating the code
updating the fork
update main branch
updating the branch
Update fork
Upating the fork
Updating fork
Updating fork
|
This pull request introduces 1 alert when merging 7efcbe0 into b4cd0b8 - view on LGTM.com new alerts:
|
Jeanstaquet
changed the title
Jeanstaquet
changed the title
|
Hi, |
|
Nice improvement! |
ostjen
changed the title
|
Hey @Jeanstaquet I'm designer at Rocket.Chat and I'd like to thank you for this contribution. |
Contributor
|
There were some conflicts. This item was edited and added into a new PR: #23766 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Seeing only the name of the person you are not adding is not practical in my opinion because two people can have the same name. Moreover, you can't see the username of the person you want to add in the dropdown. So I changed that and created another selection of users to show the username as well. I made this change so that it would appear in the key place for creating a room and adding a user.
Before:
2021-04-19.20-50-17.mp4
After:
2021-04-19.20-38-14.mp4
Issue(s)
Fixes #21474
Steps to test or reproduce
Further comments
Let me know if you want other changes