Skip to content

Comments

[FIX] Success toast shows up when "Custom Sound" upload fails#21697

Closed
PriyaBihani wants to merge 1 commit intoRocketChat:developfrom
PriyaBihani:patch-3
Closed

[FIX] Success toast shows up when "Custom Sound" upload fails#21697
PriyaBihani wants to merge 1 commit intoRocketChat:developfrom
PriyaBihani:patch-3

Conversation

@PriyaBihani
Copy link
Contributor

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

While adding a custom sound in the administration, if user uses an invalid name the success toast shows up along with the other error toasts. This PR introduces a check so that false success alert doesn't show up but only error toasts show up.

Previously

Screen.Recording.2021-04-21.at.2.45.16.PM.mov

Now
Success toast doesn't show up

Issue(s)

Steps to test or reproduce

  1. Go to the administration panel.
  2. Go to custom sounds.
    3)Add a custom sound with invalid name.

Further comments

@PriyaBihani
Copy link
Contributor Author

PriyaBihani commented Apr 27, 2021

@tiagoevanp can you merge this?

@KevLehman KevLehman requested a review from a team April 27, 2021 21:43
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@dougfabris
Copy link
Member

@PriyaBihani thanks for your contribution! Already fixed here #25128

@dougfabris dougfabris closed this Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants