Conversation
ggazzo
changed the title
ggazzo
approved these changes
Apr 23, 2021
gabriellsh
added a commit
that referenced
this pull request
Apr 23, 2021
…bold * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Discussions not showing in Safari (#21270) Regression: Reconnection not working properly due to changes on ECHD Proxy (#21741) Regression: Fix scroll to bottom (#21731) [FIX] Toolbox icons order (#21739) Regression: Bold, italic and strike render (Original markdown) (#21747) Regression: Fix room not returning to the previous room after directory (#21757) Regression: Fix services Docker image build (#21750)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Modified regex to avoid spaces between the marked text and the symbols. Also made it possible to apply the three markings at the same time, independing of order.
Issue(s)
Steps to test or reproduce
These should not be parsed.
Further comments