Skip to content

Comments

[FIX] Omnichannel Activity Monitor closing chats returned to the queue#21782

Merged
renatobecker merged 8 commits intodevelopfrom
regression-april-21/vistorInactivityJobMigration
Apr 27, 2021
Merged

[FIX] Omnichannel Activity Monitor closing chats returned to the queue#21782
renatobecker merged 8 commits intodevelopfrom
regression-april-21/vistorInactivityJobMigration

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Apr 24, 2021

Proposed changes (including videos or screenshots)

Fix VisitorInactivityMonitor is still monitoring rooms that returned to Queue Chats

Issue(s)

Steps to test or reproduce

  1. Set the following 2 settings in Admin -> Omnichannel -> Sessions as below
    image
  2. Start a new Livechat conversation
  3. Send a message from Agent to visitor. Now within 20 seconds, move this chat back to queue.
  4. At the end of 20 seconds, check the latest system message within the queued chat. You should see a system message saying that the chat was place on-hold

Further comments

@murtaza98 murtaza98 requested a review from renatobecker April 24, 2021 07:46
@renatobecker renatobecker changed the title [Regression] Fix Omnichannel VisitorInactivityMonitor Bug [FIX] Omnichannel Activity Monitor closing chats returned to the queue Apr 24, 2021
@renatobecker renatobecker added this to the 3.14.0 milestone Apr 24, 2021
@murtaza98 murtaza98 requested a review from renatobecker April 26, 2021 17:54
@murtaza98 murtaza98 marked this pull request as draft April 27, 2021 11:10
@murtaza98 murtaza98 marked this pull request as ready for review April 27, 2021 11:18
@renatobecker renatobecker merged commit aff6653 into develop Apr 27, 2021
@renatobecker renatobecker deleted the regression-april-21/vistorInactivityJobMigration branch April 27, 2021 20:43
@sampaiodiego sampaiodiego mentioned this pull request Apr 28, 2021
vanhoang1107 pushed a commit to vanhoang1107/Rocket.Chat that referenced this pull request May 13, 2021
* rocketchat/master: (273 commits)
  Bump version to 3.14.0
  Bump version to 3.14.0-rc.4
  bump fuselage (RocketChat#21841)
  [FIX] Duplicated header on admin's user contextualbar (RocketChat#21810)
  Bump version to 3.14.0-rc.3
  Bump Apps-Engine version (RocketChat#21840)
  [FIX][Enterprise] Omnichannel simultaneous chat limit is not properly checking the limit by department (RocketChat#21839)
  Fix node_modules cache path again
  Regression: Reactivate direct conversations only if all involved users are active (RocketChat#21714)
  Bump version to 3.14.0-rc.2
  [FIX] Omnichannel Activity Monitor closing chats returned to the queue (RocketChat#21782)
  Fix node_modules cache path
  Regression: Problem with Importer's logs (RocketChat#21812)
  Chore: Add tests for teams.update REST endpoint (RocketChat#21653)
  QoL improvements to add channel to team flow (RocketChat#21778)
  Chore: Cache EE node_modules on CI (RocketChat#21831)
  Regression: team sync not accepting multiple teams (RocketChat#21768)
  regression: Italic being parsed with surrounding non-whitespace text (RocketChat#21815)
  Regression: Unread Threads Header and List (RocketChat#21816)
  Fix attachment previews. (RocketChat#21746)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants