[fix] Disable eslint import/no-unresolved#21835
Closed
im-adithya wants to merge 1 commit intoRocketChat:developfrom
Closed
[fix] Disable eslint import/no-unresolved#21835im-adithya wants to merge 1 commit intoRocketChat:developfrom
im-adithya wants to merge 1 commit intoRocketChat:developfrom
Conversation
Contributor
Author
|
@MartinSchoeler Please review this :) |
Member
|
@im-adithya I am not sure, but I think #21831 solves the lint issues on CI checks. |
Contributor
Author
|
No @yash-rajpal, this doesn't apply to CI checks but covers it (as it includes linting tests) and this PR disables eslint for the specific file. |
Member
|
Yes, was just confirming it. Also if you would do npm install in EE folder too, I don't think lint would give import errors on these files. EE folder also now requires node modules. |
Member
|
As @yash-rajpal mentioned, in local you should run I'm closing this since it's not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This was causing build failures so I have disabled eslint.
Issue(s)
Steps to test or reproduce
Further comments