[IMPROVE] CAS popup login size input type#21907
Merged
sampaiodiego merged 2 commits intoRocketChat:developfrom May 21, 2021
Deepak-learner:fix-bug1
Merged
[IMPROVE] CAS popup login size input type#21907sampaiodiego merged 2 commits intoRocketChat:developfrom Deepak-learner:fix-bug1
sampaiodiego merged 2 commits intoRocketChat:developfrom
Deepak-learner:fix-bug1
Conversation
Contributor
Author
|
@rafaelblink , @Sing-Li , @sampaiodiego can you please review this PR. |
KevLehman
approved these changes
May 8, 2021
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
@sampaiodiego do we need a migration for this kind of change?
sampaiodiego
changed the title
Member
no, this is evaluated every startup and the type is overwritten |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #21906
In CAS, 'Login Popup width' and 'Login popup height' input box is now only accepting integer value as a correct input value.
Screenshot :
