[FIX] Uploading files from WebDAV#21948
Merged
sampaiodiego merged 3 commits intodevelopfrom May 6, 2021
Merged
Conversation
milton-rucks
previously approved these changes
May 5, 2021
sampaiodiego
requested changes
May 5, 2021
| try { | ||
| return await this._client.createDirectory(path); | ||
| } catch (error) { | ||
| console.error(error); |
Member
There was a problem hiding this comment.
if this is important to keep, can you please use Logger instead? we should try not use console since we cannot control its output.
Member
Author
There was a problem hiding this comment.
Nope, this were debug logs. Let me modify
| try { | ||
| return await this._client.getDirectoryContents(path); | ||
| } catch (error) { | ||
| console.error(error); |
sampaiodiego
approved these changes
May 6, 2021
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Fixes #20939
Fixes #21045
Steps to test or reproduce
Further comments