[FIX] Error when you look at the members list of a room in which you are not a member#21952
Merged
sampaiodiego merged 34 commits intoRocketChat:developfrom May 10, 2021
Jeanstaquet:CheckProfileUser
Merged
[FIX] Error when you look at the members list of a room in which you are not a member#21952sampaiodiego merged 34 commits intoRocketChat:developfrom Jeanstaquet:CheckProfileUser
sampaiodiego merged 34 commits intoRocketChat:developfrom
Jeanstaquet:CheckProfileUser
Conversation
updating the code
updating the code
updating the fork
update main branch
updating the branch
Update fork
Upating the fork
Updating fork
Updating fork
Updating fork
Updating Fork
Updating fork
Updating fork
Updating fork
Updating fork
Updating fork
Update branch
Jeanstaquet
changed the title
dougfabris
added
the
stat: ready to merge
dougfabris
approved these changes
May 5, 2021
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Before, when you look at the members of a room in which you are not a member the app crashed, i corrected this problem.
Indeed, there was a check on each currentSubscription. to see if it was not undefined except on currentSubscription.blocker
2021-05-05.03-12-08.mp4
Issue(s)
Fixes #21953
Steps to test or reproduce
Further comments