[FIX] Notify with sound first message in queue list#21969
Merged
renatobecker merged 10 commits intodevelopfrom May 17, 2021
Merged
[FIX] Notify with sound first message in queue list#21969renatobecker merged 10 commits intodevelopfrom
renatobecker merged 10 commits intodevelopfrom
Conversation
…queue-sound-notification
…queue-sound-notification
ggazzo
reviewed
May 14, 2021
…queue-sound-notification
…Rocket.Chat into fix/queue-sound-notification
renatobecker
previously requested changes
May 15, 2021
Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
Member
|
This is not as I had suggested, the code for emitting the sound was duplicated and like all the logic evaluating the settings. Where you call the method I don't really care. but if for some reason we remove the CustouSound or any other preference, you will quickly notice. |
sampaiodiego
pushed a commit
that referenced
this pull request
May 19, 2021
* notify with sound queue chat * fix typo and remove comments * use added event * Change audio check Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
sampaiodiego
pushed a commit
that referenced
this pull request
May 19, 2021
* notify with sound queue chat * fix typo and remove comments * use added event * Change audio check Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com> Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
Merged
|
Hello everyone! |
Merged
Contributor
Author
Thanks for your comment. Suggestion saved in our list! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
close #20554
Steps to test or reproduce
Further comments