[FIX] App crashes when downloads come from WebDAV and the server is not available#21985
Merged
sampaiodiego merged 2 commits intodevelopfrom May 20, 2021
Merged
[FIX] App crashes when downloads come from WebDAV and the server is not available#21985sampaiodiego merged 2 commits intodevelopfrom
sampaiodiego merged 2 commits intodevelopfrom
Conversation
KevLehman
commented
May 7, 2021
| this.store.getReadStream(file._id, file) | ||
| .on('error', () => { | ||
| console.error('An error ocurred when fetching the file'); | ||
| res.writeHead(400); |
Member
Author
There was a problem hiding this comment.
What can be handled better by the FE? A 500 with a message? The current 400 + log? A 404?
Member
There was a problem hiding this comment.
I'd say we should reply either 503 or 500..
KevLehman
commented
May 20, 2021
sampaiodiego
approved these changes
May 20, 2021
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ilable
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments