[FIX] Emails being sent with HTML entities getting escaped multiple times#21994
Merged
sampaiodiego merged 2 commits intoRocketChat:developfrom May 21, 2021
Merged
Conversation
…slated incorrectly in the sent email.
|
Hi! |
gabrieleiro
approved these changes
May 17, 2021
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
fixes an issue where if password contains special HTML character like &, in the email it would end up something like
&password was going through multiple escapeHTML function calls
secure&123 => secure&123 => secure&123Issue(s)
Closes #21986
Steps to test or reproduce
edit user from admin panel
enable the option "Set random password and send by email"
check your email or see logs for email html
Further comments