Merged
Conversation
dougfabris
force-pushed
the
fix/display-mode
branch
2 times, most recently
from
5d8c3f2 to
e90ce2b
Compare
dougfabris
reviewed
May 19, 2021
dougfabris
reviewed
May 19, 2021
dougfabris
reviewed
May 19, 2021
dougfabris
reviewed
May 19, 2021
dougfabris
reviewed
May 19, 2021
dougfabris
reviewed
May 19, 2021
|
This pull request introduces 1 alert when merging 99876ce into 2dac1dd - view on LGTM.com new alerts:
|
gabriellsh
force-pushed
the
fix/display-mode
branch
from
99876ce to
f6836d5
Compare
dougfabris
reviewed
May 19, 2021
Member
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
@gabriellsh Everything is working well, thanks! Let's wait for the BE because of the migration.
KevLehman
reviewed
May 20, 2021
server/startup/migrations/v225.js
Outdated
| { _id: user._id }, | ||
| { | ||
| $set: { | ||
| 'settings.preferences.displayAvatars': !user.settings.preferences.hideAvatars, |
Member
There was a problem hiding this comment.
it's possible for a user to not to have the hideAvatars in preferences? (because if so, this can crash)
Member
Author
There was a problem hiding this comment.
I don't think it's gonna crash, but it will have the wrong behaviour. It shouldn't be set if the value is undefined. I'll push a fix for this.
KevLehman
reviewed
May 20, 2021
server/startup/migrations/v225.js
Outdated
| 'settings.preferences.sidebarShowDiscussion': 1, | ||
| }, | ||
| }, | ||
| { multi: true }, |
Member
There was a problem hiding this comment.
You don't need multi: true here since you're just updating one entry
KevLehman
approved these changes
May 20, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments