[FIX] App license error detail message removed#22091
Merged
Conversation
d-gubert
commented
May 20, 2021
|
|
||
| const ref = useRef(apps); | ||
| ref.current = apps; | ||
| // ref.current = apps; |
Member
Author
There was a problem hiding this comment.
I was confused by the existence of this line and I commented it, so I could ask here if it really is doing the exact same thing of the line above or if I'm missing something 😛
Member
There was a problem hiding this comment.
I`m 99.8% sure (maybe 99.9%) its some kind of "workaround/gambiarra" to use the same apps list in many places, I think not sure
ggazzo
approved these changes
May 21, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Banner in the App Detail page that showed a message explaining why the license validation had failed was removed previously, likely during the React rewrite.
We're bringing it back.
Issue(s)
Steps to test or reproduce
Further comments