Skip to content

Comments

Regression: Add "User left team" message type#22109

Merged
sampaiodiego merged 4 commits intodevelopfrom
user-left-team-message
May 26, 2021
Merged

Regression: Add "User left team" message type#22109
sampaiodiego merged 4 commits intodevelopfrom
user-left-team-message

Conversation

@matheusbsilva137
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • Add 'ult' system message type, which is sent when a user leaves a team ("Has left the team.").

Issue(s)

Task - ClickUp

Steps to test or reproduce

Select a team in the sidebar and Leave it. When the user leaves the team, the system message "Has left the team." will be sent in the team's main channel. The message when a user leaves a channel/group remains the same.

Further comments

@matheusbsilva137 matheusbsilva137 requested a review from a team May 21, 2021 20:08
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we're going this path, what about having a "User joined team" as well? since people can join public teams by themselves, which currently also triggers a "User joined channel" message.

@sampaiodiego sampaiodiego merged commit 21fc380 into develop May 26, 2021
@sampaiodiego sampaiodiego deleted the user-left-team-message branch May 26, 2021 12:50
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants