[FIX] Avoid last admin deactivate itself#22949
Merged
Conversation
ostjen
changed the title
…ket.Chat into lastAdminDeactivateItself
|
This pull request introduces 1 alert when merging 60ae3e9 into e764914 - view on LGTM.com new alerts:
|
KevLehman
previously requested changes
Aug 18, 2021
KevLehman
reviewed
Aug 20, 2021
| return false; | ||
| } | ||
|
|
||
| const userAdmin = Users.findOneAdmin(userId.count); |
Member
There was a problem hiding this comment.
This should only be called if you're actually trying to disable the user, like inside the following if statement
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
matheusbsilva137
approved these changes
Oct 14, 2021
Merged
| method: 'removeUserFromRole', | ||
| action: 'Remove_last_admin', | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
We should add this check to removing role if role is admin. Some people seem to keep removing the last admin. 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Co-authored-by: @Kartik18g
Issue(s)
Steps to test or reproduce
Further comments