Skip to content

[FIX] "Read Only" and "Allow Reacting" system messages are missing in rooms#23037

Merged
matheusbsilva137 merged 10 commits intodevelopfrom
fix/missing-system-messages
Sep 23, 2021
Merged

[FIX] "Read Only" and "Allow Reacting" system messages are missing in rooms#23037
matheusbsilva137 merged 10 commits intodevelopfrom
fix/missing-system-messages

Conversation

@matheusbsilva137
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • Add system message to notify changes on the "Read Only" setting;
  • Add system message to notify changes on the "Allow Reacting" setting;
  • Fix "Allow Reacting" setting's description (updated from "Only authorized users can write new messages" to "Only authorized users can react to messages").
    system-messages

Issue(s)

Task - ClickUp

Steps to test or reproduce

  1. Create a new channel (not read-only);
  2. Go to Room Information > Edit > Read Only and turn this setting on. Expected Behavior: a system message with the text "Room set as Read Only by your.user" should be sent;
  3. Turn the "Read Only" setting off. Expected Behavior: a system message with the text "Room added writing permission by your.user" should be sent;
  4. Turn the "Read Only" setting on again and then turn the "Allow Reacting" setting on. Expected Behavior: a system message with the text "Room allowed reacting by matheus.barbosa by your.user" should be sent;
  5. Turn the "Allow Reacting" setting off. Expected Behavior: a system message with the text "Room disallowed reacting by your.user" should be sent;
    IMPORTANT: Save the changes after changing each setting (the system messages will only be sent after saving).

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Aug 26, 2021

This pull request fixes 2 alerts when merging c51ee57 into c59d8fd - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Aug 26, 2021

This pull request fixes 2 alerts when merging 0b02d6e into 591ca0c - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 10, 2021

This pull request fixes 2 alerts when merging a685c83 into d03ee51 - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

ostjen
ostjen previously approved these changes Sep 14, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2021

This pull request fixes 2 alerts when merging 30be105 into 0118745 - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 16, 2021

This pull request fixes 2 alerts when merging 7491847 into 0a293e5 - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

ostjen
ostjen previously approved these changes Sep 22, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 22, 2021

This pull request fixes 2 alerts when merging 062def1 into e34af8d - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 22, 2021

This pull request fixes 2 alerts when merging 5904e97 into e34af8d - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2021

This pull request fixes 2 alerts when merging 0bca6d8 into 558bab0 - view on LGTM.com

fixed alerts:

  • 2 for Superfluous trailing arguments

@matheusbsilva137 matheusbsilva137 merged commit 37034a5 into develop Sep 23, 2021
@matheusbsilva137 matheusbsilva137 deleted the fix/missing-system-messages branch September 23, 2021 18:49
@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments