[FIX] Add check before placing chat on-hold to confirm that contact sent last message#23053
Merged
[FIX] Add check before placing chat on-hold to confirm that contact sent last message#23053
Conversation
KevLehman
reviewed
Aug 27, 2021
KevLehman
approved these changes
Aug 30, 2021
Member
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
The backend part looks good, and I did a small check on the FE, but will prefer @MartinSchoeler or @tiagoevanp 's review to go ahead with this 🎉
tiagoevanp
approved these changes
Aug 31, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
The gif image describes the wrong behavior
The agent can set Hold to a chat even if the customer was the one that sent the last message
Steps to test or reproduce
Further comments
Also converted the endpoint file to typescript