Skip to content

[FIX] Can't edit profile information if any field update setting is disabled#23110

Merged
matheusbsilva137 merged 12 commits intodevelopfrom
fix/edit-user-info
Sep 23, 2021
Merged

[FIX] Can't edit profile information if any field update setting is disabled#23110
matheusbsilva137 merged 12 commits intodevelopfrom
fix/edit-user-info

Conversation

@matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Sep 3, 2021

Proposed changes (including videos or screenshots)

  • Check which fields have been updated before throwing errors in validateUserEditing.

Issue(s)

Task - ClickUp

Steps to test or reproduce

  1. Go to Administration > Accounts and disable "Allow Username Change", "Allow Email Change", "Allow Custom Status Message" and "Allow Name Change";
  2. Still logged in as an admin, go to your own profile under Administration > Users;
  3. Try to add/remove any role. Expected behavior: these operations should be performed succesfully;
  4. Try to update the Username, Name, Email and Custom Status Message fields (one at a time). Expected behavior: these operations should not be performed succesfully;
  5. Select any other user's profile , then repeat steps 3 and 4. Expected behavior: these operations should be performed succesfully.
  6. Enable all the options that have been disabled in step 1, then repeat step 3, 4 and 5. Expected behavior: these operations should be performed succesfully.

Further comments

ostjen
ostjen previously approved these changes Sep 14, 2021
ostjen
ostjen previously approved these changes Sep 14, 2021
@matheusbsilva137 matheusbsilva137 merged commit 897440b into develop Sep 23, 2021
@matheusbsilva137 matheusbsilva137 deleted the fix/edit-user-info branch September 23, 2021 19:02
@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
@hatung
Copy link

hatung commented Oct 16, 2021

hi, I got an error when call update user with my users was registered without email.

POST: api/v1/users.update
Response:

{
    "success": false,
    "error": "Cannot read property '0' of undefined"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments