Merged
Conversation
#23089) * Change way emails are validated on livechat registerGuest method * Apply MR comments
* add extra verification before creating banner * dismiss banners wrongly emitted for enterprise deploys * remove from CE servers that don't have customOAuthEnabled * fix GE * remove console log * await settings find * ldap and saml Co-authored-by: Gabriel Casals <83978645+casalsgh@users.noreply.github.com>
ggazzo
approved these changes
Sep 7, 2021
|
#23137 - When I used the https://releases.rocket.chat/latest/download url to download the expected 3.18.1 release it returned a undocumented 4.0.0 version. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2021-09-06 · 1 🚀 · 1 🐛 · 1 🔍 · 4 👩💻👨💻Engine versions
12.22.16.14.13.4, 3.6, 4.0, 4.21.27.1🚀 Improvements
🐛 Bug fixes
🔍 Minor changes
Regression: Auth banner for EE (#23091)
Dimisses auth banners assigned to EE admins and prevents new ones from appearing.
👩💻👨💻 Core Team 🤓