Skip to content

[FIX] Rewrite missing webRTC feature#23172

Merged
ggazzo merged 9 commits intodevelopfrom
fix/webrtc
Oct 20, 2021
Merged

[FIX] Rewrite missing webRTC feature#23172
ggazzo merged 9 commits intodevelopfrom
fix/webrtc

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Sep 10, 2021

Proposed changes (including videos or screenshots)

Issue(s)

Closes #22496
Closes #20207
Closes #21362

Steps to test or reproduce

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Sep 10, 2021

This pull request introduces 1 alert and fixes 1 when merging 3bb8019 into d03ee51 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Implicit operand conversion

@dougfabris dougfabris reopened this Sep 11, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 11, 2021

This pull request fixes 1 alert when merging 07de3a5 into d03ee51 - view on LGTM.com

fixed alerts:

  • 1 for Implicit operand conversion

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2021

This pull request fixes 1 alert when merging 0cb7397 into d8a779a - view on LGTM.com

fixed alerts:

  • 1 for Implicit operand conversion

@lgtm-com
Copy link

lgtm-com bot commented Sep 24, 2021

This pull request fixes 1 alert when merging 26f608d into 370a7b9 - view on LGTM.com

fixed alerts:

  • 1 for Implicit operand conversion

@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2021

This pull request fixes 1 alert when merging 26109fa into 2252e0c - view on LGTM.com

fixed alerts:

  • 1 for Implicit operand conversion

@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2021

This pull request fixes 1 alert when merging 97bf793 into 2252e0c - view on LGTM.com

fixed alerts:

  • 1 for Implicit operand conversion

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2021

This pull request fixes 1 alert when merging 1a2386a into 764d6da - view on LGTM.com

fixed alerts:

  • 1 for Implicit operand conversion

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2021

This pull request fixes 1 alert when merging 1b5c262 into 579e7d2 - view on LGTM.com

fixed alerts:

  • 1 for Implicit operand conversion

@ggazzo ggazzo merged commit 0d1c8b6 into develop Oct 20, 2021
@ggazzo ggazzo deleted the fix/webrtc branch October 20, 2021 02:00
@sampaiodiego sampaiodiego mentioned this pull request Oct 28, 2021
@danielpotthast
Copy link

It’s not working here.

@dougfabris
Copy link
Member Author

dougfabris commented Nov 12, 2021

@danielpotthast Thanks for reporting. There's an issue related to the Room context making it difficult to use the webRTC feature, where we need to open the UserInfo multiple times! I believe soon we're going to have a proper solution to improve it.

@lwl0820
Copy link

lwl0820 commented Aug 4, 2023

@danielpotthast Thanks for reporting. There's a issue related to the Room context making difficult to use the webRTC feature, where we need to open the UserInfo multiple times! I believe soon we're going to have a proper solution to improve this thing.

It still not working in version 4.x,5.x and latest 6.x.
5.x and 6.x can't use webrtc completely.

@danielpotthast
Copy link

Sad but true – you can’t trust in „soon“ statements.
There will be no fix (except webRTC is then a paid feature).

@dougfabris
Copy link
Member Author

Hello @linwuliao @danielpotthast

webRTC was deprecated in our 5.0.0 release #26225 because it wasn't working properly and due to our efforts on the Video Conference feature.

@danielpotthast I do have some ideas to provide a scalable webRTC SFU feature in Rocket.Chat
If you're interested to help with that please let me know!

Sorry for not updating you about it in this PR previously.


Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

@lwl0820
Copy link

lwl0820 commented Aug 8, 2023

Hello @linwuliao @danielpotthast

webRTC was deprecated in our 5.0.0 release #26225 because it wasn't working properly and due to our efforts on the Video Conference feature.

@danielpotthast I do have some ideas to provide a scalable webRTC SFU feature in Rocket.Chat If you're interested to help with that please let me know!

Sorry for not updating you about it in this PR previously.

Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

Thank you for your work.
I downgrade my instance to version 3.9.7(the last version that can use WebRTC),but this version may have some security issues according to https://www.cvedetails.com/vulnerability-list/vendor_id-17468/Rocket.chat.html.
Why Webrtc is still existed in workspace in latest version? Is it possible to recover in the future?
jitsi is a powerfull meeting solution,but it must be installed by market although it is free.
If I need run a standalone and offline instance in private network, I can't find any solution for voice and video call.

@dougfabris
Copy link
Member Author

@linwuliao I'm sorry to hear you had to downgrade.
We still use webRTC in Omnichannel/Livechat, and because of that the code is still there!
I got your point related to using Jitsi and I will reach out to the product team about this use case. As soon as I get some news I will warn you if there are some plans to be back the feature for team collaboration.

@ealbers
Copy link

ealbers commented Mar 6, 2024

Hello @linwuliao @danielpotthast

webRTC was deprecated in our 5.0.0 release #26225 because it wasn't working properly and due to our efforts on the Video Conference feature.

@danielpotthast I do have some ideas to provide a scalable webRTC SFU feature in Rocket.Chat If you're interested to help with that please let me know!

Sorry for not updating you about it in this PR previously.

Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

@danielpotthast i am interested in help with that. Is that still an option?

@ealbers
Copy link

ealbers commented Mar 6, 2024

Hello @linwuliao @danielpotthast
webRTC was deprecated in our 5.0.0 release #26225 because it wasn't working properly and due to our efforts on the Video Conference feature.
@danielpotthast I do have some ideas to provide a scalable webRTC SFU feature in Rocket.Chat If you're interested to help with that please let me know!
Sorry for not updating you about it in this PR previously.
Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

Thank you for your work. I downgrade my instance to version 3.9.7(the last version that can use WebRTC),but this version may have some security issues according to https://www.cvedetails.com/vulnerability-list/vendor_id-17468/Rocket.chat.html. Why Webrtc is still existed in workspace in latest version? Is it possible to recover in the future? jitsi is a powerfull meeting solution,but it must be installed by market although it is free. If I need run a standalone and offline instance in private network, I can't find any solution for voice and video call.

@wlg1024 I am interested in your ideas on the WebRTC for Rocket.Chat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.10.0 broke WebRTC Members-list page does not open when WebRTC video call is started WebRTC: video and audio chat not working

6 participants

Comments