[BREAK] Moved advanced oAuth features to EE#23201
Merged
pierre-lehnen-rc merged 24 commits intodevelopfrom Sep 24, 2021
Merged
Conversation
ostjen
changed the title
pierre-lehnen-rc
changed the title
ostjen
changed the title
pierre-lehnen-rc
requested changes
Sep 22, 2021
Contributor
pierre-lehnen-rc
left a comment
pierre-lehnen-rc
left a comment
There was a problem hiding this comment.
Other than the issues in the comments, can you also replace the callbacks object with an EventEmitter just for OAuth?
pierre-lehnen-rc
force-pushed
the
oauth_ee
branch
from
a0a5ffa to
c979035
Compare
pierre-lehnen-rc
approved these changes
Sep 24, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As already announced, we're moving "merge roles from SSO" and "map roles/groups to channels" oAuth settings to the enterprise version.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments