Skip to content

[FIX] Sidebar not closing when clicking in Home or Directory on mobile view#23218

Merged
ggazzo merged 6 commits intodevelopfrom
fix/mobile-directory-and-home
Sep 24, 2021
Merged

[FIX] Sidebar not closing when clicking in Home or Directory on mobile view#23218
ggazzo merged 6 commits intodevelopfrom
fix/mobile-directory-and-home

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Sep 16, 2021

Proposed changes (including videos or screenshots)

Additional fixed

  • Merge Burger menu components into a single component
  • Show a badge with no-read messages in the Burger Button:
    image
  • remove useSidebarClose hook

Issue(s)

Steps to test or reproduce

  • Click in Home and Directory buttons in sidebar using a mobile browser

Further comments

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added 1 .js files, please convert to ts(x).
client/components/BurgerMenu/BurgerMenu.stories.js

@github-actions github-actions bot dismissed their stale review September 16, 2021 20:05

js files removed

@dougfabris dougfabris changed the title [FIX] Home and Directory doesn't open when clicked on mobile view [FIX] Sidebar not closing when clicking in Home or Directory on mobile view Sep 16, 2021
@dougfabris dougfabris requested a review from a team September 16, 2021 20:17
ggazzo
ggazzo previously approved these changes Sep 24, 2021
@ggazzo ggazzo merged commit 370a7b9 into develop Sep 24, 2021
@ggazzo ggazzo deleted the fix/mobile-directory-and-home branch September 24, 2021 04:53
@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments