[IMPROVE] Load code highlighting languages on demand and fixes on new message parser#23232
Merged
[IMPROVE] Load code highlighting languages on demand and fixes on new message parser#23232
Conversation
|
probably closes #22280 |
ggazzo
force-pushed
the
fix/message-parser
branch
2 times, most recently
from
b9cee5d to
3da442b
Compare
ggazzo
force-pushed
the
fix/message-parser
branch
from
3da442b to
668e501
Compare
ggazzo
changed the title
sampaiodiego
requested changes
Sep 22, 2021
Member
|
maybe it is a good time do update? |
sampaiodiego
requested changes
Sep 23, 2021
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
functionality wise it seems good.
I'll just reinforce the need of an upgrade.. current version is also showing a message on browser's console:
| "Message_BadWordsWhitelist": "Remove words from the Blacklist", | ||
| "Message_BadWordsWhitelistDescription": "Add a comma-separated list of words to be removed from filter", | ||
| "Message_Characther_Limit": "Message Character Limit", | ||
| "Message_Code_highlight": "Message Code highlight", |
Member
There was a problem hiding this comment.
I don't think this is explanatory enough to admins..
I'd consider something like "Code languages highlights"
And also add a description to explain better what it does, like "Comma separated list of languages (link to list of supported languages https://github.com/highlightjs/highlight.js/tree/9.18.5#supported-languages ) that will be used to highlight code blocks"
sampaiodiego
approved these changes
Sep 23, 2021
sampaiodiego
changed the title
sampaiodiego
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Now we have this setting called 'Code highlighting languages list' where you can define the languages that you want to be loaded by default.
Issue(s)
closes #20766
closes #8989
closes #21184
closes #7707
closes #21184
closes #5218
closes #11675
closes #19933
Steps to test or reproduce
Further comments