[BREAK] Remove old migrations up to version 2.4.14#23277
Merged
sampaiodiego merged 7 commits intodevelopfrom Sep 23, 2021
Merged
[BREAK] Remove old migrations up to version 2.4.14#23277sampaiodiego merged 7 commits intodevelopfrom
sampaiodiego merged 7 commits intodevelopfrom
Conversation
|
This pull request fixes 4 alerts when merging 650005a into 88b2698 - view on LGTM.com fixed alerts:
|
ggazzo
approved these changes
Sep 23, 2021
Contributor
|
@debdutdeb This one is one you will want to pay attention to from snap perspective. Gotta make sure every snap update goes through a 3.x version no matter what they chose to do by staying back a version on an old track like 1.x or 2.x 🙏 [edit] |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
To update to version 4.0.0 you'll need to be running at least version 3.0.0, otherwise you might loose some database migrations which might have unexpected effects.
This aims to clean up the code, since upgrades jumping 2 major versions are too risky and hard to maintain, we'll keep only migration from that last major (in this case 3.x).
Another changes included in this PR:
Migrationsclass - functionality remains the same thoughaddMigration()instead ofMigrations.add()Still missing some code clean up.
Issue(s)
Steps to test or reproduce
Further comments