Skip to content

[IMPROVE] Support Markdown on Livechat Custom Message Setting#23450

Closed
murtaza98 wants to merge 3 commits intodevelopfrom
settings/markdown-type
Closed

[IMPROVE] Support Markdown on Livechat Custom Message Setting#23450
murtaza98 wants to merge 3 commits intodevelopfrom
settings/markdown-type

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Oct 13, 2021

Proposed changes (including videos or screenshots)

Since we're now adding support for markdown text on Livechat offline Instructions message, we're adding this PR to provide a markdown editor in place of the generic text setting for the corresponding livechat setting
image

Issue(s)

Steps to test or reproduce

Further comments

Note: I've moved the Markdown components I needed for this PR out of the EE folder and into our general community folder since this setting is also present on community version

@murtaza98 murtaza98 marked this pull request as draft October 13, 2021 08:21
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added 1 .js files, please convert to ts(x).
client/views/admin/settings/inputs/MarkdownSettingInput.stories.js

@github-actions github-actions bot dismissed their stale review October 13, 2021 10:20

js files removed

@murtaza98 murtaza98 marked this pull request as ready for review October 13, 2021 11:29
@murtaza98 murtaza98 requested a review from a team October 13, 2021 11:38
@murtaza98 murtaza98 changed the title [IMPROVE] Support Markdown on Livechat Custom Message [IMPROVE] Support Markdown on Livechat Custom Message Setting Oct 13, 2021
@KevLehman
Copy link
Member

It works 🤔 but I feel the interaction a bit buggy

  • Cut (ctrl-x) sometimes work, sometimes doesn't
  • Link button doesn't work
  • Sometimes, when deleting a long text, you're left with just one character that you cannot remove

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@murtaza98 murtaza98 closed this Aug 16, 2022
@tassoevan tassoevan deleted the settings/markdown-type branch September 28, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments