[FIX] Delay start of email inbox#23521
Conversation
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
I dont think this combination startup + defer makes sense, if you need some "delay" to solve some race condition or something I'm quite sure we can find a better way
| Meteor.defer(() => { | ||
| configureEmailInboxes(); | ||
| }); |
There was a problem hiding this comment.
what is the point doing this? what does this actually fix?
There was a problem hiding this comment.
Well, the issue with this one is that the email inbox depends on a setting being set (Routing_algo). Since the inbox can receive emails before the setting is set (because the setting now runs on a meteor startup) this was aiming to delay the execution of that inbox configuration (there is a task to replace this with a setting watch or another kind of delay too)
There was a problem hiding this comment.
Noticed there's a watchOnce now for settings, I'll use it and change this to that 👀
|
and please check if you can #22588 |
|
Oh, I didn't know this feature affected the other (didn't know the other existed tho) I'll take a look at it later 👀 |
3 participants
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments