[FIX] Resolves issue with E2E default settings on private and Direct#23544
Closed
TheDigitalEagle wants to merge 2 commits intoRocketChat:developfrom
Closed
[FIX] Resolves issue with E2E default settings on private and Direct#23544TheDigitalEagle wants to merge 2 commits intoRocketChat:developfrom
TheDigitalEagle wants to merge 2 commits intoRocketChat:developfrom
Conversation
Fix typo changing from E2E_Enabled to E2E_Enable
Made private and DM E2E settings public.
TheDigitalEagle
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log:
This has been tested and confirmed working in our internal systems.
Additional notes:
We have further implemented Enforced E2E in our own company build for Private and DM (meaning users cannot disable). We'd be happy to upstream if there's interest as we're sure there's customers who require that as much as we did.