Skip to content

Chore: add index on appId + associations for apps_persistence collection #23675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-gubert merged 9 commits into from
Nov 22, 2021
Merged

Chore: add index on appId + associations for apps_persistence collection #23675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5d9aaef
add index on appId and associations for persistence table
KevLehman Nov 9, 2021
f711893
Merge branch 'develop' into chore/index-on-apps-persistence
KevLehman Nov 19, 2021
c669f89
remove old appId index
KevLehman Nov 19, 2021
414c4a1
init app engine before using persist model
KevLehman Nov 22, 2021
bed4fe3
Merge branch 'develop' into chore/index-on-apps-persistence
KevLehman Nov 22, 2021
9e83884
new migration
KevLehman Nov 22, 2021
ab69e2a
Merge branch 'develop' into chore/index-on-apps-persistence
KevLehman Nov 22, 2021
97b8748
ouch
KevLehman Nov 22, 2021
62bce6a
Merge branch 'develop' into chore/index-on-apps-persistence
KevLehman Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/server/models/apps-persistence-model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export class AppsPersistenceModel extends Base {
constructor() {
super('apps_persistence');

this.tryEnsureIndex({ appId: 1 });
this.tryEnsureIndex({ appId: 1, associations: 1 });
}

// Bypass trash collection
Expand Down
1 change: 1 addition & 0 deletions server/startup/migrations/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,5 @@ import './v244';
import './v245';
import './v246';
import './v247';
import './v248';
import './xrun';
12 changes: 12 additions & 0 deletions server/startup/migrations/v248.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { addMigration } from '../../lib/migrations';
import { Apps } from '../../../app/apps/server/orchestrator';

addMigration({
version: 248,
up() {
// we now have a compound index on appId + associations
// so we can use the index prefix instead of a separate index on appId
Apps.initialize();
return Apps._persistModel?.tryDropIndex({ appId: 1 });
},
});