Chore: Enable prefer-optional-chain ESLint rule for TypeScript files#23786
Merged
sampaiodiego merged 2 commits intodevelopfrom Dec 20, 2021
Merged
Chore: Enable prefer-optional-chain ESLint rule for TypeScript files#23786sampaiodiego merged 2 commits intodevelopfrom
sampaiodiego merged 2 commits intodevelopfrom
Conversation
sampaiodiego
previously approved these changes
Nov 25, 2021
KevLehman
previously approved these changes
Nov 25, 2021
8bcbf2c
sampaiodiego
approved these changes
Dec 20, 2021
KevLehman
approved these changes
Dec 20, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
— Rich Skrenta
Mixing two problem domains in code is prone to errors. In this small example
we're (1) checking the nullity of
yand (2) attributingy.ztox, where (2) is clearly the main problem we're solving with code. The optional chaining is a good technique to handle nullity as a mere implementation detail:Attributing
y.ztoxis more easily readable than the nullity check ofy.This PR aims to add
@typescript-eslint/prefer-optional-chainrule to ESlint configuration at warning level.Issue(s)
Steps to test or reproduce
Further comments