Skip to content

Comments

Chore: added last login to users.list#23846

Merged
sampaiodiego merged 1 commit intodevelopfrom
users_list_last_login
Dec 20, 2021
Merged

Chore: added last login to users.list#23846
sampaiodiego merged 1 commit intodevelopfrom
users_list_last_login

Conversation

@ostjen
Copy link
Contributor

@ostjen ostjen commented Dec 2, 2021

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ostjen ostjen requested a review from sampaiodiego December 2, 2021 17:58
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of adding lastLogin to the results for every call, we should instead respect defaultLimitedUserFieldsToExclude for users without the required permission

@ostjen ostjen requested a review from sampaiodiego December 8, 2021 17:18
@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@sampaiodiego sampaiodiego merged commit 04ad659 into develop Dec 20, 2021
@sampaiodiego sampaiodiego deleted the users_list_last_login branch December 20, 2021 13:27
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants