[FIX] DMs being created with username instead of user's name#23848
[FIX] DMs being created with username instead of user's name#23848sampaiodiego merged 4 commits intodevelopfrom
Conversation
|
@gabriellsh hey! |
hey @ankar84 ! Reading through that issue, I believe this is the fix. Thanks for the tip! I'll close it when this is merged. |
sampaiodiego
left a comment
There was a problem hiding this comment.
do you mind adding tests @gabriellsh ? 🤗
thx for the fix anyways
sampaiodiego
left a comment
There was a problem hiding this comment.
found a missing await on the Promise.all call..
added other suggestions for improving readability and consistency :)
|
oh, awesome job overall btw.. that's a single line fix that required a lot of tests to prove it works.. thanks for this great improvements |
|
#11598 says that the issue is also in 3.18. Shouldnt the fix be backported to that major version too? |
Proposed changes (including videos or screenshots)
Issue(s)
closes #23093
Steps to test or reproduce
Further comments