Skip to content

Comments

[FIX] DMs being created with username instead of user's name#23848

Merged
sampaiodiego merged 4 commits intodevelopfrom
fix/dmName
Dec 9, 2021
Merged

[FIX] DMs being created with username instead of user's name#23848
sampaiodiego merged 4 commits intodevelopfrom
fix/dmName

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Dec 2, 2021

Proposed changes (including videos or screenshots)

Issue(s)

closes #23093

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh changed the title [FIX] Dm's not respect useRealName setting. [FIX] Dm's not respecting useRealName setting. Dec 2, 2021
@gabriellsh gabriellsh requested review from a team December 2, 2021 18:41
@gabriellsh gabriellsh added this to the 4.2.0 milestone Dec 2, 2021
@dougfabris dougfabris modified the milestones: 4.2.0, 4.3.0 Dec 2, 2021
@ankar84
Copy link

ankar84 commented Dec 3, 2021

@gabriellsh hey!
What do you think is that PR fix that issue #23093 ?
Or it fix different issue?

@gabriellsh
Copy link
Member Author

@gabriellsh hey! What do you think is that PR fix that issue #23093 ? Or it fix different issue?

hey @ankar84 ! Reading through that issue, I believe this is the fix. Thanks for the tip! I'll close it when this is merged.

dougfabris
dougfabris previously approved these changes Dec 3, 2021
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind adding tests @gabriellsh ? 🤗

thx for the fix anyways

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a missing await on the Promise.all call..

added other suggestions for improving readability and consistency :)

@sampaiodiego
Copy link
Member

oh, awesome job overall btw.. that's a single line fix that required a lot of tests to prove it works.. thanks for this great improvements

@sampaiodiego sampaiodiego changed the title [FIX] Dm's not respecting useRealName setting. [FIX] DMs being created with username instead of user's name Dec 9, 2021
@sampaiodiego sampaiodiego merged commit c0b4120 into develop Dec 9, 2021
@sampaiodiego sampaiodiego deleted the fix/dmName branch December 9, 2021 11:37
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
@a89h4ya
Copy link

a89h4ya commented Jan 28, 2022

#11598 says that the issue is also in 3.18. Shouldnt the fix be backported to that major version too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 4.1.2 does not show the real name of new users in several places.

5 participants