Regression: Toolbox render item

[dougfabris]

Proposed changes (including videos or screenshots)

Issue(s)

Closes #23883

Steps to test or reproduce

Further comments

Missed something

[ggazzo]

try to update fuselage to the last version before ant then check the resulto

[dougfabris]

try to update fuselage to the last version before ant then check the resulto

@ggazzo Even using the latest version we need this fix

[tassoevan]

@ggazzo @dougfabris

I'm mad. This component has a insane amount of crappy code at first glance:

• code commented out without, ironically, any remarks why is deactivated;
• atrociously large render props;
• memo for two properties;
• useMutableCallback for a value that may be used as default value;
• Enough logic to be put in a separate hook;
• any, too much any, even an any assertion.

And above it all, I don't know what id and value mean to even review it. Please folks, fix it.

[ggazzo]

@ggazzo @dougfabris

I'm mad. This component has a insane amount of crappy code at first glance:

• code commented out without, ironically, any remarks why is deactivated;
• atrociously large render props;
• memo for two properties;
• useMutableCallback for a value that may be used as default value;
• Enough logic to be put in a separate hook;
• any, too much any, even an any assertion.

And above it all, I don't know what id and value mean to even review it. Please folks, fix it.

I'm pretty sure you are aware this component was created based on the Menu (and that component is a mess as well), and the intention for this pull request is only "fit" the type introduced on fuselage

but you are 100% right there are a lot of space to improvements