Chore: update docker image base to latest node 12 patch#23875
Merged
Chore: update docker image base to latest node 12 patch#23875
Conversation
Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
|
|
sampaiodiego
requested changes
Dec 20, 2021
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
there was a new patch in the meanwhile 😬
Member
|
@debdutdeb I've updated the node version on github workflows and everywhere else, so we're sure we're building and testing using the same version as we're publishing our docker images 👍 |
sampaiodiego
approved these changes
Dec 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Debdut Chakraborty debdut.chakraborty@rocket.chat
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments