Skip to content

Comments

[IMPROVE] Update "Message Erasure Type" setting's description#23879

Merged
matheusbsilva137 merged 2 commits intodevelopfrom
improve/message-erasure-description
Dec 8, 2021
Merged

[IMPROVE] Update "Message Erasure Type" setting's description#23879
matheusbsilva137 merged 2 commits intodevelopfrom
improve/message-erasure-description

Conversation

@matheusbsilva137
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • Improves the "Message Erasure Type" setting's description by providing more details regarding the expected behavior of each option ("Keep Messages and User Name", "Delete All Messages" and "Remove link between user and messages");
  • Remove outdated translations (for this setting's description).

Issue(s)

Fix #22360
Fix #18524
Task - ClickUp

Steps to test or reproduce

Go to Admin > Message > Message erasure type. The setting's description should be displayed as follows:
new-description

Further comments

@ostjen ostjen self-requested a review December 6, 2021 19:27
@matheusbsilva137 matheusbsilva137 merged commit da41c6c into develop Dec 8, 2021
@matheusbsilva137 matheusbsilva137 deleted the improve/message-erasure-description branch December 8, 2021 20:26
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Message Erasure Type" not working for direct messages DMs gone when deleting user (even though setting says they'll be kept)

2 participants