Skip to content

Comments

[FIX] Popover position for arabic languages#23888

Merged
ggazzo merged 4 commits intoRocketChat:developfrom
yash-rajpal:fix/popover-arabic
Dec 14, 2021
Merged

[FIX] Popover position for arabic languages#23888
ggazzo merged 4 commits intoRocketChat:developfrom
yash-rajpal:fix/popover-arabic

Conversation

@yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Dec 7, 2021

Proposed changes (including videos or screenshots)

Issue(s)

Closes #23599

Steps to test or reproduce

  • change the RC language to some arabic language.
  • Userdrop down goes out of the screen on rightside

Further comments

@ali-alhaidary
Copy link

#23599

@ali-alhaidary
Copy link

#22923

@ggazzo ggazzo merged commit e62d8d4 into RocketChat:develop Dec 14, 2021
@dougfabris dougfabris added this to the 4.3.0 milestone Dec 14, 2021
@yash-rajpal yash-rajpal deleted the fix/popover-arabic branch December 14, 2021 08:53
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
@ali-alhaidary
Copy link

Still in v4.3.0

@dougfabris
Copy link
Member

dougfabris commented Dec 30, 2021

Still in v4.3.0

@ali-alhaidary Can you provide more details? It's working fine here:
image

@ali-alhaidary
Copy link

Still in v4.3.0

@ali-alhaidary Can you provide more details? It's working fine here: image

#23599

still in 4.3.1

@dougfabris
Copy link
Member

@ali-alhaidary Please, provide some screenshots or logs. We couldn't reproduce it anymore!!

@JeroenAdam
Copy link

I can confirm this is solved. Upgraded from 4.2.2 to 4.3.1.

@ali-alhaidary
Copy link

#23599
Still in v4.3.2

@dougfabris
Copy link
Member

@ali-alhaidary As I'm trying to say to you I'm not able to reproduce the error. Just sending us that the issue remains won't help us at all. Please, provide more details!
The screenshot above is an attempt to reproduce. Am I missing something?
image

@ali-alhaidary
Copy link

still in 4.5.1

@ali-alhaidary
Copy link

ali-alhaidary commented Mar 19, 2022

still in 4.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avatar overlap on user name in RTL

5 participants