[FIX] Jitsi call already ended

[Aman-Maheshwari]

• I have read the Contributing Guide
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

• Fix Jitsi timeout update -- which caused the "Jitsi call already ended" error when trying to join a call some time after its creation;

Before

before_jitsi_call_ended.mp4

After

after_jitisi_call_already_ended.mp4

Issue(s)

Fix #23903

Steps to test or reproduce

Mentioned in the issue

Further comments

[dudanogueira]

hi @Aman-Maheshwari !! Thanks for yet another awesome PR.

I have no access to your email from your github profile. Can you drop me an email at duda.nogueira@rocket.chat or a message at https://open.rocket.chat/direct/duda.nogueira??

Thanks!

Thanks!

[Aman-Maheshwari]

@dudanogueira Thank you for the appreciation. 😄

[arunodhayam10d]

Hi Guys, I am using rocket chat in docker version 4.2.0. I am also facing this call ended issue. Is this fixed in docker-version??

[CLAassistant]

All committers have signed the CLA.

[matheusbsilva137]

Merged! Thanks @Aman-Maheshwari for proposing the changes and @yash-rajpal for working on some improvements 🤗

[camherry]

Hi,
The bug still seems to be present, I'm currently on version 4.3.2 rocket-chat docker image, and when a second participant wants to join me in video jitsi, he gets message "call already ended", so he has to click on the phone icon to join me, what generates a new button in the conversation.
Thanks for your help.

[bseclier]

Hello,
I can confirm that it still doesn't work in 4.3.1 nor in 4.3.2...
This bug has been fixed in the past, but it is back, it doesn't give a good image to the solution in my university :(

[bseclier]

Still here in 4.4.1 :(

[matheusbsilva137]

Hey @bseclier and @camherry . Thanks for pointing this is still an issue for you
However, I couldn't reproduce it in 4.4.1. Could you please provide more info about your environment?
Are you experiencing this issue while following the same steps as in the "Before" video in this PR's description?

[bseclier]

Hello @matheusbsilva137
I've made more tests, I appears that the problem occurs only with the desktop client. I've tried with both our test and production server instances (docker 4.4.1 for test and docker 4.3.1 for production).
I want the jitsi to open in a new window. In firefox and chromium, it opens a new tab and everything works well.
In the desktop client, it opens a popup and the problem become the same as the "Before" video.

My desktop client is the snap package with 3.7.7 version (it was the same behavior with 3.7.X). I hope it'll help.
Cheers,

[himpierre]

Same experience here. It worked for a while. Now with the desktop client 3.7.7 the "call already ended" problem is back. Server version 4.4.1. What puzzles me is with desktop client 3.7.7 and the setting "always open in a new window" the desktop client now does not open a tab in the default web browser anymore (firefox for example) but spawns a popup from the desktop client.

[jeanfbrito]

Same experience here. It worked for a while. Now with the desktop client 3.7.7 the "call already ended" problem is back. Server version 4.4.1. What puzzles me is with desktop client 3.7.7 and the setting "always open in a new window" the desktop client now does not open a tab in the default web browser anymore (firefox for example) but spawns a popup from the desktop client.

The description says that will use the browser if this is not enabled. Then you need to disable to use browser for video chat.
"When set Video Chat will be opened using an application's window, otherwise the default browser will be used."

[himpierre]

@jeanfbrito Interesting! Thanks!. When disabling this setting (did not know it existed) the video chat opens in firefox again and guess what, the "call already ended" problem went away. Maybe with this information you are able to fix the desktop client Jean?

[bseclier]

Hello @jeanfbrito
This is a workaround, indeed, but it doesn't solve the initial problem :)

[jeanfbrito]

@himpierre @bseclier
We are investigating this issue on Desktop App. If it happens outside the desktop app, please let us know.

[bseclier]

Thank you @jeanfbrito
As I said above, I have no problem with firefox nor chromium, only in the desktop app.