[NEW] Show Omnichannel room icon based on source definition#23912
Merged
[NEW] Show Omnichannel room icon based on source definition#23912
Conversation
|
|
ggazzo
reviewed
Dec 20, 2021
d-gubert
reviewed
Dec 21, 2021
d-gubert
changed the title
d-gubert
approved these changes
Dec 22, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR is a feature, in summary, it will allow the App developer to send a custom icon for the room that his/her App may create on use.
With that in mind, this PR adds the definition and types that will be accessed by the frontend.
Also, this PR is connected to another PR on Rocket.Chat.Apps.Engine.
Issue(s)
Steps to test or reproduce
Further comments