Merged
Conversation
* Fix teams.removeMembers client usage * chore: api test * fix: definition test Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
KevLehman
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2021-12-10 · 1 🎉 · 4 🐛 · 1 🔍 · 7 👩💻👨💻Engine versions
12.22.16.14.13.6, 4.0, 4.2, 4.4, 5.01.28.1🎉 New features
Create new setting to clean local storage at end of chats (#23821)
Include setting to handle with and clear the localStorage on Livechat widget.
This behavior is only possible to happen when [NEW] Introduce
clearLocalStorageWhenChatEndedsetting logic Rocket.Chat.Livechat#666 merged and released.🐛 Bug fixes
Error when creating an inactive user in admin panel (#23859)
usersInRolearray used to send email to activate a user.Segmentation fault on CentOS 7 due to outdated
sharp(#23796)Upgrades
sharpto avoid a segmentation fault on CentOS 7 during startup related tosharp.nodebeing loaded viaprocess.dlopen().Suggested as a fix for versions
4.0.xand4.1.x.teams.removeMembers client usage (#23857)
Wrong button for non trial apps (#23861)
This PR solves a bug on the marketplace that was happening with WhatsApp where it was displaying a trial button even though it didn't have a free trial period. The new verification I've added checks if the app is subscription-based and then checks if it has 0 trial days in all of its tiers. If it does, it shows a subscribe button. If it doesn't, it displays a trial button. Also, I've exposed the itsEnterpriseOnly flag as an extra measure in the case of apps like Facebook Messenger that are enterprise-only and consequently should show the subscribe button.
Before:
After:
🔍 Minor changes
👩💻👨💻 Core Team 🤓