Conversation
gabriellsh
force-pushed
the
fix/otr_event
branch
from
f6dfa62 to
f2dc62e
Compare
murtaza98
approved these changes
Dec 17, 2021
Contributor
murtaza98
left a comment
murtaza98
left a comment
There was a problem hiding this comment.
Tested and the fix is working. It has also not affected the Livechat WebRTC calling change, which we'd earlier added ... where unfortunately this issue originated :(
|
|
tassoevan
approved these changes
Dec 17, 2021
sampaiodiego
approved these changes
Dec 17, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
A rule on the user notification streamer was changed recently, and the check for writing on the streamer was wrong. Changed it to allow all logged users.
Issue(s)
Closes #23874
Closes #20791
Steps to test or reproduce
Further comments