[FIX] Omnichannel Current chats pagination not working#24039
Merged
[FIX] Omnichannel Current chats pagination not working#24039
Conversation
murtaza98
requested review from
a team and
tiagoevanp
and removed request for
tiagoevanp
Member
|
@murtaza98 , is this a fix or a regression? Cause i'm not sure if it was working before candidate 🙈 |
Member
|
This is behaving a bit weird 🤔
Can you take a look at those? 👀 |
Member
|
Yes, I think Filter by fields is not working as of now. #23970 Fixes this issue. Please apply this fix and check if filter works. 👀 |
Member
|
Hey, I integrated the changes from the other PR into this one 👀 and fixed the Omni-specific issue. Here, the issue is that both, GenericTable & FilterByText were trying to filter by params, and they were not liking each other. Moved the filters to GenericTable again should also fix it the issue on the other view 🤗 |
Contributor
Author
|
New changes look good to me 👍 Just added a small change to remove the unused method. Thanks, guys!! |
Harmeet221
approved these changes
Dec 30, 2021
amolghode1981
approved these changes
Dec 30, 2021
sampaiodiego
pushed a commit
that referenced
this pull request
Jan 5, 2022
Co-authored-by: Kevin Aleman <kevin.aleman@rocket.chat>
Merged
gabriellsh
added a commit
that referenced
this pull request
Jan 19, 2022
…hat into improve/setup-wizard * 'improve/setup-wizard' of github.com:RocketChat/Rocket.Chat: Regression: Fix handling of http requests in apps bridge (#24211) Bump version to 4.3.2 [FIX] Integration section crashing opening in My Account (#24068) Chore: Update Apps-Engine to 1.29.2 (#24171) [FIX] App Framework Enable hanging indefinitely (#24158) [FIX] CSV Importer failing to import users (#24090) Fix Engagement Dashboard API requests (#24142) [FIX] MAU when using micro services (#24204) [IMPROVE] Limit recent emojis to 27 (#24210) Bump version to 4.3.1 Bump Fuselage packages [FIX][APPS] Action buttons not removed when app is disabled or uninstalled (#24107) [FIX][APPS] Prevents emails from being sent when apps framework is disabled (#24105) [FIX] Ensure Firefox 91 ESR support (#24096) Chore: Update Livechat (#24091) [FIX] Omnichannel enabled setting not working when creating rooms (#24067) [FIX] Enter not working on modal's multi-line input (#23981) [FIX] Omnichannel Current chats pagination not working (#24039)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Omnichannel - Current Chats not refreshing while clicking on pagination
Steps to test or reproduce
Steps to reproduce:
Expected Behavior:
After navigating between the pages it is supposed to refresh and display different chats
Actual Behavior:
Even clicking on any page option it doesn't refresh and the chats remain the same of the first page
Further comments